search

dotnet / format

Home for the dotnet-format command
MIT License
1.94k stars 172 forks source link

Add explicit System.Text.Json dependency #1887

Closed NikolaMilosavljevic closed 1 year ago

NikolaMilosavljevic commented 1 year ago

Contributes to: https://github.com/dotnet/source-build/issues/3540

In source-build, Microsoft.Build package dependency is pulling a transitive System.Text.Json dependency from PSB. The fix is to simply add an explicit System.Text.Json dependency.

I'm not 100% sure if changes in eng/Version.Details.xml are necessary.

NikolaMilosavljevic commented 1 year ago

@mthalman @MichaelSimons @mmitche

NikolaMilosavljevic commented 1 year ago

@mmitche @JoeRobich @sharwell what is the correct branch that would flow into sdk's release/6.0.1xx? I picked release/6.0.2xx but there is also the release/6.x branch.

There is a Darc subscription, but last build was in 2021:

https://github.com/dotnet/format (.NET 6.0.1xx SDK) ==> 'https://github.com/dotnet/sdk' ('release/6.0.1xx')
  - Id: 0bfc4365-847b-4126-21c4-08d96bf86fb9
  - Update Frequency: EveryBuild
  - Enabled: False
  - Batchable: False
  - Merge Policies:
    Standard
  - Last Build: 20211027.3 (68bc36719088c86b0ff01334039b0611741b8276)
JoeRobich commented 1 year ago

Whoops, seems like we missed a branch. I've added a release/6.0.1xx branch with appropriate subscriptions which publishes to the expected channel. @sharwell I opened https://github.com/dotnet/roslyn-tools/pull/1355 to update the code flow so update flow appropriately.