search

dotnet / format

Home for the dotnet-format command
MIT License
1.92k stars 174 forks source link

Update Roslyn to 4.8.0-3.23474.1 #1959

Closed JoeRobich closed 11 months ago

JoeRobich commented 11 months ago

Update Roslyn to a preview 3 build to match the forthcoming .NET 8 RC2 SDK.

arkalyanms commented 11 months ago

@Cosifne can we add this to the Tiger checklist if it is not already. Usually dotnet format flies under the Tiger radar.

Cosifne commented 11 months ago

Is that possible to let arcade handle the version update? @JoeRobich

Cosifne commented 11 months ago

~Is that possible to let arcade handle the version update? @JoeRobich~ Nevermind I see the linked arcade PR

Cosifne commented 11 months ago

Looks like Roslyn Workspace is introducing a new dependencies:

image image

@JoeRobich do you want me to add this to https://github.com/dotnet/format/blob/main/eng/SourceBuildPrebuiltBaseline.xml ? Or is there any convention to solve this?

Cosifne commented 11 months ago

@Cosifne can we add this to the Tiger checklist if it is not already. Usually dotnet format flies under the Tiger radar.

We can sync at the standup to clarify which repo should be taken care by Tiger. I think it should be part of the arcade flow work. (which this is something unusual)

JoeRobich commented 11 months ago

@JoeRobich do you want me to add this to https://github.com/dotnet/format/blob/main/eng/SourceBuildPrebuiltBaseline.xml ?

@Cosifne I am not quite sure of the proper fix. @mthalman can you point us in the right direction?

mthalman commented 11 months ago

Yes, this can be added to the prebuilt baseline. This is allowed in this case because the prebuilts are limited to this repo and introduced as a dependency of M.CA. That version of M.CA gets overridden by the full product source-build in the VMR. Since it's overridden there, the prebuilts don't occur. They only apply to this repo.

JoeRobich commented 11 months ago

Thanks @mthalman! Updated the baseline.