search

dotnet / format

Home for the dotnet-format command
MIT License
1.92k stars 174 forks source link

[release/8.x] Update dependencies from dotnet/arcade #1967

Closed dotnet-maestro[bot] closed 10 months ago

dotnet-maestro[bot] commented 11 months ago

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency attribute were produced in a build used as input to the parent dependency's build. See Dependency Description Format

From https://github.com/dotnet/arcade

ViktorHofer commented 10 months ago

Why is this repository using the UseDotNet AzDO task? Arcade already restores the SDK automatically. cc @mmitche

jjonescz commented 10 months ago

Removed UseDotNet AzDO task, seems it's not needed (and started a signed build to verify it's not needed there either; but it looks like it doesn't work without it).

Now only tests are failing with https://github.com/dotnet/razor/issues/9342:

System.TypeLoadException : Could not load type 'Enumerator' from assembly 'Microsoft.CodeAnalysis, Version=4.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.

Which means we need to wait until VS 17.8P4 is available on CI machines where this problem should be fixed I think.

Plus will probably need to do something similar to this: https://github.com/dotnet/format/commit/fc7a9bf1842254945458774c3c9ee780a904e029.

ViktorHofer commented 10 months ago

Which means we need to wait until VS 17.8P4 is available on CI machines where this problem should be fixed I think.

I think we require VS 17.8 P3 which is currently prepared by the Core Engineering team and should be available later today. @marcpopMSFT / @jaredpar is that right?

jjonescz commented 10 months ago

I think we require VS 17.8 P3 which is currently prepared by the Core Engineering team and should be available later today.

If it works with 17.8P3 then great, but I think regular preview queue will have 17.8P3 and scouting preview queue will have 17.8P4, so we can choose.

ViktorHofer commented 10 months ago

Plus will probably need to do something similar to this: https://github.com/dotnet/format/commit/fc7a9bf1842254945458774c3c9ee780a904e029.

When I last worked on this, I was told that we only want to update the SHAs when there's a reason to do so. The dotnet-format tool must be invoked with the dotnet/format repo's SDK because that's the toolchain that builds the tool. I added this commit a while ago to enforce that requirement: https://github.com/dotnet/format/pull/1812/commits/31d13fac3c35318315905d00ffc498ea7fbde3b4

Unfortunately I just noticed that my changes were undone with the following commits that came in at a later point:

I don't understand why this was done, maybe @JoeRobich can tell?

EDIT: reverted Joe's changes and made it possible to use the parent repo sdk, i.e. for project-system.

JoeRobich commented 10 months ago

I don't understand why this was done, maybe @JoeRobich can tell?

EDIT: reverted Joe's changes and made it possible to use the parent repo sdk, i.e. for project-system.

I made the change when updating MSBuildLocator to v1.6.1. It was having difficulties locating a workable SDK for the integration tests. I see we are on 1.6.10 now, so it may be better behaved.

jjonescz commented 10 months ago

This looks good now but we still need to fix signed builds.

ViktorHofer commented 10 months ago

Should we merge this in meanwhile and fix the remaining issues separately?

jjonescz commented 10 months ago

Merging this would break signed builds for release/8.x so it wouldn't flow into the SDK.

jjonescz commented 10 months ago

Test run of a signed build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2299802&view=results