search

dotnet / format

Home for the dotnet-format command
MIT License
1.92k stars 174 forks source link

Revert "Revert "Merge pull request #1920 from dotnet/darc-main-c4635c16-72c5-…" #2026

Closed MiYanni closed 9 months ago

MiYanni commented 9 months ago

Reverts: https://github.com/dotnet/format/pull/1983

Summary

This is a coordinated update for dotnet/command-line-api in the repos that DARC flows to. There needs to be only 1 version of this dependency for Source Build to function properly. See: https://github.com/dotnet/sdk/pull/33126

MiYanni commented 9 months ago

CC @jjonescz @MichaelSimons

(I would have requested as reviewers, but I don't seem to have the capability to do that in this repo)

jjonescz commented 9 months ago

Can I merge this or does it need to be coordinated somehow?

MiYanni commented 9 months ago

@jjonescz We were waiting for the Roslyn integration test issue to be resolved. Plus, runtime had merged theirs ahead of time and I had to revert that. So, I gotta revert that revert once Roslyn is ready. Tracking in this comment: https://github.com/dotnet/sdk/pull/33126#issuecomment-1811730153

MiYanni commented 9 months ago

@jjonescz This now can be merged immediately. The SDK PR and Runtime PR have been merged.