dotnet / format

Home for the dotnet-format command
MIT License
1.92k stars 171 forks source link

[main] Update dependencies from dotnet/roslyn #2065

Closed dotnet-maestro[bot] closed 6 months ago

dotnet-maestro[bot] commented 6 months ago

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

ViktorHofer commented 6 months ago

@dotnet/source-build-internal can you please take a look at the new prebuilts?

ellahathaway commented 6 months ago

This is related to https://github.com/dotnet/source-build/issues/3968. Working on updating Arcade dependencies which should fix this.

mthalman commented 6 months ago

It's not Arcade that's causing this.

Format has a dependency on both Microsoft.Build and Microsoft.CodeAnalysis. Microsoft.Build.17.3.2 brings a transitive dependency on System.Collections.Immutable.6.0.0 while Microsoft.CodeAnalysis.4.9.0 new brings a new transitive dependency on System.Collections.Immutable.8.0.0. Since System.Collections.Immutable.8.0.0 isn't in SBRP it causes a prebuilt. But it shouldn't be defined in SBRP because that dependency won't be required in the VMR. Instead, since Microsoft.CodeAnalysis is defined as a dependency, it will be lifted to the live version and not have an 8.0.0 dependency at all. So I believe the right thing to do here is to simply add these prebuilts to the repo's baseline.