search

dotnet / format

Home for the dotnet-format command
MIT License
1.91k stars 172 forks source link

--binarylog option broken #2094

Open sbomer opened 5 months ago

sbomer commented 5 months ago

--binarylog no longer seems to work. I bisected dotnet-format, and it was broken by https://github.com/dotnet/format/commit/f58bc29a159f43a71e6ac21fd2734f5d10807a72.

This related issue is mentioned: https://github.com/dotnet/roslyn/issues/70674. According to https://github.com/dotnet/roslyn/discussions/71950#discussion-6174863, broken by https://github.com/dotnet/roslyn/pull/70469 as part of an intentional change to the API.

JoeRobich commented 5 months ago

Let me start by saying that a fix is planned for this break in behavior. Although, depending on how it is resolved in Roslyn, there may be a change in how it is used in dotnet-format.

However, since binary logs are a pretty big hammer, I think it is good to touch base and ensure we are providing the right feature here. These questions are open to anyone using the --binarylog option.

How are you using the generated log? What information is it providing for you? What questions are you answering with it?

sbomer commented 5 months ago

The use case I had was this: @LakshanF and I were developing with some locally-built analyzers, and we wanted to make sure that dotnet format was picking up the right analyzer dlls by checking the binlog.

sharwell commented 4 months ago

However, since binary logs are a pretty big hammer, I think it is good to touch base and ensure we are providing the right feature here.

I'm not sure I agree with this. In my experience, binary logs are the only hammer that matters when looking at build issues.