dotnet / format

Home for the dotnet-format command
MIT License
1.93k stars 173 forks source link

[main] Update dependencies from dotnet/roslyn #2126

Closed dotnet-maestro[bot] closed 7 months ago

dotnet-maestro[bot] commented 7 months ago

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

lewing commented 7 months ago

cc @dotnet/source-build-internal

NikolaMilosavljevic commented 7 months ago

cc @dotnet/source-build-internal

I've pushed the fix: https://github.com/dotnet/format/pull/2126/commits/9695675caaaf7fde0b2347b6af33a0aa39779d6d

cc @jmarolf @sharwell

This is something that was introduced by roslyn and showed up as following errors in source-build log:

/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24114.1/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : 5 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24114.1/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24114.1/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : Package IDs are:
/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24114.1/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : System.Configuration.ConfigurationManager.8.0.0
/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24114.1/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : System.Diagnostics.EventLog.8.0.0
/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24114.1/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : System.Security.Cryptography.ProtectedData.8.0.0
/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24114.1/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : System.Security.Permissions.8.0.0
/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24114.1/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : System.Windows.Extensions.8.0.0

The fix was to add these packages as new UsagePattern elements in IgnorePatterns section.