VS: allowStaleResults is hardcoded false - Githubissues

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio

https://dotnet.microsoft.com/languages/fsharp

MIT License

3.91k stars 785 forks source link

VS: allowStaleResults is hardcoded false #16487

Open majocha opened 10 months ago

majocha commented 10 months ago

In Editor, ParseAndCheckDocument extension method has only one single call site: https://github.com/dotnet/fsharp/blame/ec08a4c7f856bb965b2bb67bb039b898d0e59268/vsintegration/src/FSharp.Editor/LanguageService/WorkspaceExtensions.fs#L207

allowStaleResults is false here, which means these options have no effect:

For context, this feature was introduced in #2315, but it looks like it has been defunct for quite some time now.

This is not high priority issue, but we should probably either chuck away the code path, along with the not working user options or re-enable this?

abonie commented 1 month ago

It could be enabled, though default should definitely stay false. Will probably become obsolete after moving to LSP