search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.88k stars 783 forks source link

FS1118 on inlined function in private module from SDK 8.0.300 #17161 #17168

Closed KevinRansom closed 4 months ago

KevinRansom commented 4 months ago

Fixes: https://github.com/dotnet/fsharp/issues/17161

This is a regression it should go into 8.0.300 /cc @vzarytovskii , @baronfel

github-actions[bot] commented 4 months ago

:warning: Release notes required, but author opted out

[!WARNING] Author opted out of release notes, check is disabled for this pull request. cc @dotnet/fsharp-team-msft

loop-evgeny commented 4 months ago

Thanks for the quick fix! Does this also fix the warning for class members?

vzarytovskii commented 4 months ago

/backport to release/dev17.10

github-actions[bot] commented 4 months ago

Started backporting to release/dev17.10: https://github.com/dotnet/fsharp/actions/runs/9130940180

github-actions[bot] commented 4 months ago

@vzarytovskii backporting to release/dev17.10 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: temp
Using index info to reconstruct a base tree...
M   src/Compiler/Optimize/Optimizer.fs
M   tests/AheadOfTime/Trimming/check.ps1
Falling back to patching base and 3-way merge...
Auto-merging tests/AheadOfTime/Trimming/check.ps1
CONFLICT (content): Merge conflict in tests/AheadOfTime/Trimming/check.ps1
Auto-merging src/Compiler/Optimize/Optimizer.fs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 temp
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

KevinRansom commented 4 months ago

@loop-evgeny, Sorry not to get back to you, it was 1:00 am last night when I propped this PR. I believe this will take care of the class issues too, I will add test cases for it and also verify #17161.