search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.88k stars 783 forks source link

Cherry pick #17176

Closed KevinRansom closed 4 months ago

KevinRansom commented 4 months ago

Fixes: https://github.com/dotnet/fsharp/issues/17161

Description

We didn't inline so good, now we do

Customer Impact

Code that compiled in previous SDKs that was correct no longer compiled when updating to 8.0.300. Users would have to make code changes to adjust to our incorrect analysis.

Regression? Yes, ...

Risk Low, we have manual and automated tests to cover this now.

github-actions[bot] commented 4 months ago

:warning: Release notes required, but author opted out

[!WARNING] Author opted out of release notes, check is disabled for this pull request. cc @dotnet/fsharp-team-msft

vzarytovskii commented 4 months ago

Do we need to bump package version, so nuget is uploaded as well?

KevinRansom commented 4 months ago

Do we need to bump package version, so nuget is uploaded as well?

Yes

Done: image

vzarytovskii commented 4 months ago

We shouldn't have merged it before tactics approval for the backport