Open edgarfgp opened 1 month ago
:white_check_mark: Found changes and release notes in following paths:
Change path Release notes path Description src/FSharp.Core
docs/release-notes/.FSharp.Core/8.0.400.md src/Compiler
docs/release-notes/.FSharp.Compiler.Service/8.0.400.md
Ready for review
/azp run
[!CAUTION] Repository is on lockdown for maintenance, all merges are on hold.
Can you explain the
RequireQualifiedAccess
reasoning here, maybe even in the comment as part of code?Is it only a temporary need caused by
new compiler + old FSharp.Core
combination, eventually to be removed?
@T-Gro So the check for RequireQualifiedAccess
is not needed at all. Turns out that when you use dotnet build
on FSharp.Compiler.Service
it uses the FSharp.Core nuget as opposed to the project reference and that is why my unit test was failing locally.
Thanks for the review
Thanks! Appreciate your consistent and meticulous approach. Do you see the light at the end of the attributes tunnel?
Yes. I have 2 more PRs and then a RFC
Follow up: https://github.com/dotnet/fsharp/pull/17173
Records compiles down to a
class
orstruct
sharplab.This PR enforces the new rules on
records
.Old rules
New Rules
[<Struct>]
Before sharplab
After
Checklist