search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.83k stars 773 forks source link

Fix MultipleDiagnosticsLoggers.Parallel deadlock #17208

Closed majocha closed 1 month ago

majocha commented 1 month ago

Description

Fixes #17205

Checklist

github-actions[bot] commented 1 month ago

:warning: Release notes required, but author opted out

[!WARNING] Author opted out of release notes, check is disabled for this pull request. cc @dotnet/fsharp-team-msft

majocha commented 1 month ago

I think this is ready.

psfinaki commented 1 month ago

@ForNeVeR maybe take a look if you have a chance :)

vzarytovskii commented 1 month ago

LGTM. I cannot imagine a scenario when this breaks (so far!)

Famous last words, but lgtm too

vzarytovskii commented 1 month ago

/run fantomas

psfinaki commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 2 pipeline(s).