search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 773 forks source link

.NET 9preview5 #17224

Closed vzarytovskii closed 6 days ago

vzarytovskii commented 1 month ago

Upgrades SDK to 9p5

github-actions[bot] commented 1 month ago

:white_check_mark: No release notes required

vzarytovskii commented 1 month ago

Some operator tests are failing with

System.Exception : Assertion: Expected -2147483648 but got 2147483647

When running Operators.int on p3, it yields -2147483648 for System.Single.MaxValue, and 2147483647 on the p4.

Operators.int (pretty much just conv.i4): https://github.com/dotnet/fsharp/blob/ef2307d18b2d97312680187b3d189a0076fdaa94/src/FSharp.Core/prim-types.fs#L4835-L4853

vzarytovskii commented 1 month ago

It's likely related to changes made in https://github.com/dotnet/runtime/pull/97529

ViktorHofer commented 2 weeks ago

@vzarytovskii just curious, will you also update to Arcade 9 soon? That would allow us to clean-up a bit of infra here.

vzarytovskii commented 2 weeks ago

@vzarytovskii just curious, will you also update to Arcade 9 soon? That would allow us to clean-up a bit of infra here.

Yup, once we done with p5 upgrade, I will be moving us to net9 by default + consuming arcade and dotnet-optimization from the NET9 channels

psfinaki commented 1 week ago

@dotnet/source-build-internal please take a look.

ViktorHofer commented 6 days ago

Source-build changes LGTM

ViktorHofer commented 6 days ago

@MichaelSimons / @mthalman can you please approve?