dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 773 forks source link

Enable Visualizer Support for F# in VS #17239

Closed mpeyrotc closed 1 month ago

mpeyrotc commented 1 month ago

Description

This PR addresses bug 361 from the VS Extensibility repo, where a customer is complaining about the lack of support of Custom Visualizers in VS for the F# language. I tested F#'s support of this scenario and did not notice any issues with it, so I feel it can be safely enabled for VS 2022. The only required change is to register the appropriate EE metric that gets consumed by VS to indicate the visualizers are supported.

Checklist

github-actions[bot] commented 1 month ago

:white_check_mark: No release notes required

abelbraaksma commented 1 month ago

Even though it may look like a small change, the impact is massive! Thanks so much for this, and maybe you can update the release-notes anyway, so that people are aware this feature is coming their way? (or is there more that needs to be done here?)

smoothdeveloper commented 1 month ago

If the test/demo can confirm it works with a System.Data.DataTable, that would be great.

related issue: https://github.com/dotnet/fsharp/issues/13482

mpeyrotc commented 1 month ago

Hello psfinaki, and smoothdeveloper! Here is a .gif showcasing the IEnumerable and DataTable Visualizers for a simple F# project.

F#

smoothdeveloper commented 1 month ago

@mpeyrotc that rocks!