dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 773 forks source link

Provide better github.dev links for updating release notes #17244

Closed auduchinok closed 1 month ago

auduchinok commented 1 month ago

Hi, I've noticed that it's possible to create a link to a specific file in a PR, like this. Would it be possible to update the CI step, so links in the comments would open files needing updates?

Thank you :)

vzarytovskii commented 1 month ago

Hi, I've noticed that it's possible to create a link to a specific file in a PR, like this. Would it be possible to update the CI step, so links in the comments would open files needing updates?

Thank you :)

It doesn't work in GitHub.dev, that's the first thing I've tried when I made the check (this is what opens when I click the link):

image
auduchinok commented 1 month ago

It doesn't work in GitHub.dev, that's the first thing I've tried when I made the check (this is what opens when I click the link)

Hm, this is strange. I get the needed tab open when I open the link:

Screenshot 2024-05-24 at 15 14 09
vzarytovskii commented 1 month ago

It keeps tabs from previous time you've opened github.dev, this is if you closed all editors, it only opens one:

image
auduchinok commented 1 month ago

Ah, what a shame 🙁

vzarytovskii commented 1 month ago

Ah, what a shame 🙁

Yeah, I tried to reverse-engineer the way how it works (if any), and didn't succeed.