search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 773 forks source link

Parser: more recovery on unfinished binary expressions #17257

Closed auduchinok closed 1 month ago

auduchinok commented 1 month ago

More parser recovery for binary expressions in more complex contexts, like:

if a =

()

Or a less simplified example:

Screenshot 2024-05-17 at 12 07 59
github-actions[bot] commented 1 month ago

:heavy_exclamation_mark: Release notes required

@auduchinok,

[!CAUTION] No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md No release notes found or release notes format is not correct
auduchinok commented 1 month ago

Hm, I see the problem with this approach here. Sad, I'll have to think more about it.