Fix full source-build product build when running R2R

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio

https://dotnet.microsoft.com/languages/fsharp

MIT License

3.82k stars 773 forks source link

Fix full source-build product build when running R2R #17259

Closed ViktorHofer closed 1 month ago

ViktorHofer commented 1 month ago

See https://github.com/dotnet/source-build/issues/4410 When building from source, we must set the RuntimeIdentifier property explicitly as otherwise the SDK defaults to the portable RID.

Also make the SDK aware of the R2R build by updating the Known* items in Directory.Build.targets and remove the AspNetCore framework references.

github-actions[bot] commented 1 month ago

:white_check_mark: No release notes required

vzarytovskii commented 1 month ago

Should auto-merge once approved by someone from SB-internal team and all comments are resolved.

vzarytovskii commented 1 month ago

Oh, for some reason it wasn't blocked by the comment. @ViktorHofer is it ok that it got merged, or does it need some more changes? We can hold on with merging to release branch and wait for fixes (if any).

kasperk81 commented 1 month ago

viktor used the same patch in sdk, everything was fine https://github.com/dotnet/sdk/commit/43ff4fdb040331b368961cd3ef12bdca86019a68. need to remove the patch once fsharp update pops up via codeflow in sdk.

ViktorHofer commented 1 month ago

exactly