Fix plain build of FSC fsproj

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio

https://dotnet.microsoft.com/languages/fsharp

MIT License

3.82k stars 773 forks source link

Fix plain build of FSC fsproj #17270

Closed vzarytovskii closed 1 month ago

vzarytovskii commented 1 month ago

We haven't tested or used dotnet build src/Compiler/FSharp.Compiler.Service.fsproj /p:BUILDING_USING_DOTNET=true, it was broken for some time now (probably when we moved proto to coreclr), but it was used in some CI/automation (maybe some devs as well sometimes).

This fixes it, fslex and fsyacc were missing $(Configuration when built, now they set it explicitly like we do in some other cases when building with plain dotnet.

github-actions[bot] commented 1 month ago

:warning: Release notes required, but author opted out

[!WARNING] Author opted out of release notes, check is disabled for this pull request. cc @dotnet/fsharp-team-msft

nojaf commented 4 weeks ago

Thank you