FS-1135 implementation - random functions for collections

Lanayx commented 3 weeks ago

Description

FS-1135 implementation

Checklist

[x] Test cases added
[ ] Performance benchmarks added in case of performance changes
[x] Release notes entry updated:
Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

Release notes files:
- If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
- If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
- If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.
Information about the release notes entries format can be found in the documentation. Example:
- More inlines for Result module. (PR #16106)
- Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363) *while! (Language suggestion #1038, PR #14238)
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

github-actions[bot] commented 3 weeks ago

:heavy_exclamation_mark: Release notes required

:white_check_mark: Found changes and release notes in following paths:

Change path Release notes path Description

src/FSharp.Core docs/release-notes/.FSharp.Core/8.0.400.md

Change path	Release notes path	Description
`src/FSharp.Core`	docs/release-notes/.FSharp.Core/8.0.400.md

Lanayx commented 3 weeks ago

Can somebody please help me pass unit tests? It fails with Expected and actual surface area don't match. To see the delta, run:

brianrourkeboll commented 3 weeks ago

Can somebody please help me pass unit tests? It fails with Expected and actual surface area don't match. To see the delta, run:

I think you might want to run something like this

$env:TEST_UPDATE_BSL=1
>> dotnet test tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests/ -c Release --filter "SurfaceArea"

That should update the baselines (sometimes you may need to run it twice), which you can then commit.

Lanayx commented 3 weeks ago

Can somebody please help me pass unit tests? It fails with Expected and actual surface area don't match. To see the delta, run:

I think you might want to run something like this
$env:TEST_UPDATE_BSL
>> dotnet test tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests -c Release --filter "SurfaceArea"
That should update the baselines (sometimes you may need to run it twice), which you can then commit.

Thanks it worked, just as I figured out it should be $env:TEST_UPDATE_BSL=1

brianrourkeboll commented 3 weeks ago

just as I figured out it should be $env:TEST_UPDATE_BSL=1

Ah, yeah, whoops

psfinaki commented 3 weeks ago

/azp run

azure-pipelines[bot] commented 3 weeks ago

Azure Pipelines successfully started running 2 pipeline(s).

Lanayx commented 3 weeks ago

@abelbraaksma you are welcome to review as well!

psfinaki commented 3 weeks ago

/azp run

azure-pipelines[bot] commented 3 weeks ago

Azure Pipelines successfully started running 2 pipeline(s).

KevinRansom commented 3 weeks ago

Why would this functionality need to exist in the core runtime library? I would imagine that they could usefully exist in a nuget package and be downloaded only when someone actually had a need for them.

Whilst I am sure there are some apps that would benefit from access to this type of functionality, I don't expect it would be wouldn't be most or even many.

FSharp.Core is already much too big, and we ship two damned versions of it. And when it gets Crossgened or Ngened it gets huge, currently 5 MB.

We need to consider mechanisms to shrink FSharp.Core and only add to it, genuinely core functionality, that support core language features.

KevinRansom commented 3 weeks ago

@smoothdeveloper posted this sugestion to the fslang suggestions thread:

https://github.com/fsharp/fslang-design/pull/732#issuecomment-2155552366

He also pointed out FSharpStats, which might be a good home for this type of functionality.

https://github.com/fslaborg/FSharp.Stats

psfinaki commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago

Azure Pipelines successfully started running 2 pipeline(s).

psfinaki commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago

Azure Pipelines successfully started running 2 pipeline(s).

psfinaki commented 5 days ago

Alright, let's get this in. Thanks for your work @Lanayx. Let's spread the word :)

dotnet / fsharp