search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 773 forks source link

Address vsix package creation change #17289

Closed KevinRansom closed 3 weeks ago

KevinRansom commented 3 weeks ago

Fixes: https://github.com/dotnet/fsharp/issues/17279

Recently we updated the microsoft.vssdk.buildtools nuget package that we use in the build, the one we originally referenced was really quite old.

This change caused us to fail some validation steps when inserting into the Visual Studio. The failure happened because a change in the VSSDK vsix package generation code changed, to include additional unnecessary .dlls in the generated .vsix file.

We had a short term fix that reverted the vssdk bnuget package we use. Here is the final fix, this uses the latest shipped release vssdk package and sets a property to stop the extra .dlls being shipped in the .vsix.

github-actions[bot] commented 3 weeks ago

:white_check_mark: No release notes required

psfinaki commented 3 weeks ago

I'll keep an eye on the insertions to see if this doesn't incidentally bring some new problems.

KevinRansom commented 3 weeks ago

It won't :-)

Famous last words