Improve completion after method/property override

Tangent-90 commented 3 weeks ago

Description

Improve completion after method/property override.

Complete the parameter list of the overriden method and call base method or throw NotImplementedException
Complete the parameter list of the overriden property and call base method or throw NotImplementedException
Completion list will exclude implemented members when triggered in an interface implementation, but not when triggered in an object expression (as cannot get the type of an obj expr from GetExprTypingForPosition, it just returns the type of interface or the super class)

Type completion after new in object expression

Fixes # (issue, if applicable)

Checklist

[x] Test cases added
[ ] Performance benchmarks added in case of performance changes
[ ] Release notes entry updated:

github-actions[bot] commented 3 weeks ago

:heavy_exclamation_mark: Release notes required

:white_check_mark: Found changes and release notes in following paths:

Change path Release notes path Description

src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

Change path	Release notes path	Description
`src/Compiler`	docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

psfinaki commented 3 weeks ago

Thanks for this, looking forward to have this in the editor! Need to think a bit if this can have any perf traps or penalties, overall - good change and testing.

baronfel commented 2 weeks ago

Can't wait for this PR and the other completions-related PR to land so I can try them out in FSAC :)

T-Gro commented 1 week ago

(Converted to draft until the parser recovery is adjusted)

dotnet / fsharp