search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 773 forks source link

Visual Studio selects the highest version of the sdk installed on the machine when executing scripts in FSI #17307

Open KevinRansom opened 2 weeks ago

KevinRansom commented 2 weeks ago

This is incorrect behavior, it should select the version of the Sdk that shipped with the VS being executed.

image

Edited: Okay, the current Fsi behaviour is this, if you start with send to interactive, it uses a global.son when present in the same directory as the script to figure out which Sdk to use. If you specify nothing it does not use a global.json instead it selects the highest framework installed, which is slightly different to what the Sdk does, it selects the Sdk that was shipped with VS.

I propose changing the no global.json specified mechanism to use the version shipped with that VS. To change the specified VS add a script and include a global.json in the directory containing the script:

When you start an F# interactive session in VS you see this: image

baronfel commented 2 weeks ago

That's debatable - any global.json the user may have would also influence SDK selection and therefore the FSI chosen.

vzarytovskii commented 2 weeks ago

That's debatable - any global.json the user may have would also influence SDK selection and therefore the FSI chosen.

This. It should take global json into account. Like it does for building.

KevinRansom commented 2 weeks ago

@baronfel , @vzarytovskii --- so are you suggesting that what we do now is correct? or perhaps that the actual final implementation requires a more rigourous analysis than is currently described above?

And could you point me to the description of Visual Studios actual behavior so that I can modify the description above.

Thanks

Kevin

KevinRansom commented 2 weeks ago

image

KevinRansom commented 2 weeks ago

Okay, the current Fsi behaviour is this, if you start with send to interactive, it uses a global.son when present in the same directory as the script to figure out which Sdk to use. If you specify nothing it does not use a global.json instead it selects the highest framework installed, which is slightly different to what the Sdk does, it selects the Sdk that was shipped with VS.

I propose changing the no global.json specified mechanism to use the version shipped with that VS. To change the specified VS add a script and include a global.json in the directory containing the script:

When you start an F# interactive session in VS you see this: image