Fix exception checks in the tests

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio

https://dotnet.microsoft.com/languages/fsharp

MIT License

3.82k stars 772 forks source link

Closed psfinaki closed 4 days ago

psfinaki commented 1 week ago

Found when reviewing this PR. The code throws ArgumentOutOfRangeException and the tests verify ArgumentException, here. Not good.

CheckThrowsExn should be adjusted to match the exception type, otherwise it only checks them within the type hierarchy.

github-actions[bot] commented 1 week ago

psfinaki commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago

Azure Pipelines successfully started running 2 pipeline(s).

psfinaki commented 5 days ago

/azp run

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 2 pipeline(s).

psfinaki commented 5 days ago

/azp run

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 2 pipeline(s).

psfinaki commented 5 days ago

/azp run

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 2 pipeline(s).