search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 772 forks source link

Fix exception throwing inconsistency #17328

Closed psfinaki closed 4 days ago

psfinaki commented 1 week ago

Another thing discovered when reviewing https://github.com/dotnet/fsharp/pull/17277. AFAIU was not intentional this way, basically copypaste error.

This doesn't seem to break anything.

github-actions[bot] commented 1 week ago

:heavy_exclamation_mark: Release notes required

:white_check_mark: Found changes and release notes in following paths:

Change path Release notes path Description
src/FSharp.Core docs/release-notes/.FSharp.Core/8.0.400.md
psfinaki commented 1 week ago

I agree with the above, I made this change to have a discussion :)

I understand this can change the behavior in theory, I wondered if it breaks something right away.

We can keep things as they are of course, I am really just thinking thinking what to do with this thing in the other PR. My goal is just to minimize the code where it promises one exception and actually throws another one.

abonie commented 5 days ago

@psfinaki please add release notes and mention there the possibility of breaking change. And if you could add a "Breaking Changes" section to https://github.com/dotnet/fsharp/blob/main/docs/release-notes/.FSharp.Core/8.0.400.md, that would be great.

psfinaki commented 5 days ago

/azp run

azure-pipelines[bot] commented 5 days ago
Azure Pipelines successfully started running 2 pipeline(s).