search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 772 forks source link

Fix or remove legacy VS tests #17330

Open psfinaki opened 1 week ago

psfinaki commented 1 week ago

CI is breaking for WindowsCompressedMetadata now.

auduchinok commented 1 week ago

Please don't remove the salsa tests. They have saved me numerous times (and likely not only me 😁). Even though I didn't like to debug them, they were the only failing ones and caught some actual regressions.

vzarytovskii commented 1 week ago

Please don't remove the salsa tests. They have saved me numerous times (and likely not only me 😁). Even though I didn't like to debug them, they were the only failing ones and caught some actual regressions.

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

auduchinok commented 1 week ago

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

Would be nice to port at least the completion tests then.

vzarytovskii commented 1 week ago

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

Would be nice to port at least the completion tests then.

Not gonna port, there will be just different completion tests for lsp