search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 772 forks source link

C# collection expression support for F# lists & sets #17359

Open brianrourkeboll opened 2 days ago

brianrourkeboll commented 2 days ago

Description

Examples

FSharpSet<int> xs = [1, 2, 3];
FSharpList<int> ys = [1, 2, 3];

Checklist

github-actions[bot] commented 2 days ago

:heavy_exclamation_mark: Release notes required

:white_check_mark: Found changes and release notes in following paths:

Change path Release notes path Description
src/FSharp.Core docs/release-notes/.FSharp.Core/8.0.400.md
brianrourkeboll commented 2 days ago

Does anyone know what needs to be done with the new C# test project I added to make the CI happy? Something about the test results needing to be in a certain place, and/or packaging/PDBs?

*Edit*: Maybe I can figure it out ![image](https://github.com/dotnet/fsharp/assets/14795984/608e54e7-335e-4e98-a3e0-3529da24ae41)
brianrourkeboll commented 1 day ago

Forgive me if I'm being obtuse, but I don't think I understand the cause of this error in the CI:

PDB0021: Document name doesn't match any pattern in Source Link: '/_1/microsoft.net.test.sdk/17.4.0/build/netcoreapp3.1/Microsoft.NET.Test.Sdk.Program.cs'

The only results on Google are https://github.com/dotnet/runtime/issues/62892 and https://github.com/dotnet/machinelearning/issues/4400, which don't help me much, since I don't understand the underlying problem.

I can see that it comes from here, but... I do not understand why this PR is triggering that.

Is there something obvious I'm missing?

github-actions[bot] commented 1 day ago

Failed to run : https://github.com/dotnet/fsharp/actions/runs/9718927879

vzarytovskii commented 18 hours ago

Do they need to be part of new project? We successfully test interop in component tests.

brianrourkeboll commented 18 hours ago

Do they need to be part of new project? We successfully test interop in component tests.

Hmm, I guess they could technically go there, although these are specifically meant test the C# compiler's handling of types from FSharp.Core and have nothing to do with the F# compiler.