dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.82k stars 772 forks source link

Set ReflectionFree if PublishAot is set, and delay that decision until after the project file has been loaded. #17362

Closed baronfel closed 2 days ago

baronfel commented 2 days ago

Description

This PR delays the default of ReflectionFree until the .target files, so the user project's PublishAot value can influence the default chosen for ReflectionFree.

Since AOT apps require ReflectionFree to be useful, this seems like a helpful default.

Fixes #17361

Checklist

github-actions[bot] commented 2 days ago

:white_check_mark: No release notes required

baronfel commented 2 days ago

Closing per note in https://github.com/dotnet/fsharp/issues/17361#issuecomment-2196996576