search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.88k stars 783 forks source link

Updating dotnet interactive to FSharp.Core and FSharp.Compiler.Service 8.0.400 causes test errors #17793

Closed KevinRansom closed 5 days ago

KevinRansom commented 6 days ago

This PR in the dotnet interactive repo updates the F# packages to the latest RTM packages.

https://github.com/dotnet/interactive/pull/3679

This causes tests issues for interactive: image

image

vzarytovskii commented 6 days ago

Issue is caused by https://github.com/dotnet/fsharp/pull/16168

FYI @DedSec256

@KevinRansom @T-Gro can you please handle the revert/fix (whatever is easier). It will need to go to both 8 and 9 asap.

T-Gro commented 6 days ago

This reproes for FSI when used with the /usesdkrefs- flag. Under it, the typedefiniton for "MemoryExtensions" signals that it does not contain extension methods (the regression added by #16168 ).

I will try a fix-forward rather than a revert here.

T-Gro commented 5 days ago

Fixed with #17799