dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.93k stars 786 forks source link

Nullness issue - null annotations on F# record members are not visible from C# #18007

Open mlaily opened 1 week ago

mlaily commented 1 week ago

Issue description

Hi! I couldn't find a definitive source or existing issue for my problem so I'm creating this issue...

Problem:

type MyRecord = {
    NonNullableString: string
    NullableString: string | null
}

With this record, I was hoping to see that NullableString would have type string? from C#, but it doesn't (it has type string).

Taking a look at ILSpy, I see that some nullness metadata are added, but on the backing field of the property only, which is not public: (internal string? NullableString@;) Image

The public properties and the constructor do not appear to have nullness metadata.

Consequence:

Interop between F# and C# is inconsistent regarding nullness: Image

I was hoping to use this feature to declare DTOs from my F# project and expose them in a web API implemented in a C# ASP.NET Core project.
Swagger/OpenAPI with Swashbuckle already support reading nullness metadata on properties to show this info in the generated specs, but because of this issue it doesn't work.

Question:

Is that behavior on purpose?

Did I miss something in the specs somewhere?

Is there any plan to change the current behavior?

Thanks.

Choose one or more from the following categories of impact

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

.NET 9

Reproducible code snippet and actual behavior

type MyRecord = {
    NonNullableString: string
    NullableString: string | null
}

Possible workarounds

No response

vzarytovskii commented 1 week ago

Yep, we need to inherit nullness attributes in this codegen.