search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.87k stars 781 forks source link

FSharp.Core XML help is not localized #2360

Open masq6r opened 7 years ago

masq6r commented 7 years ago

The quick info shows only the signature but not the help information for some F# functions: 1 Compared to a .NET method: 2

If I open the same project in VS 2015 Community the quick info shows fully.

OS: Windows 10 with latest patch VS 2017 Community RC3 Visual F# Tools extension

cartermp commented 7 years ago

On the Class Library template with RC3 + VSIX this doesn't fail:

works

Could you share the code where you noticed this?

And @vasily-kirichenko is correct; the .NET method example is Signature Help, which actually builds up information differently, so you'll likely see different info even if there isn't a regression.

masq6r commented 7 years ago

I investigated the issue a bit and found it could be a localization issue for F#. If change the language to English, I could see the full help. But when I switch to a local language like Chinese the help doesn't show for some functions. Some local text might be missing so the full help doesn't show.

cartermp commented 7 years ago

Ah! That is a bug indeed, then. Do you still get localized error messages and things like that, or is this only something you've seen in QuickInfo when highlighting an item in a completion list?

masq6r commented 7 years ago

Yes I can see the localized error messages... I guess some functions don't have the translated complete local help text (e.g. List.item)

cartermp commented 7 years ago

Okay, in that case I'll update this issue and re-open. Definitely a bug, but it's good that you're still getting other things localized. Thanks for drilling down into the issue @CodEFouR.

dsyme commented 2 years ago

Renaming this to cover the general fact that FSHarp.Core XML doc help has never been localised

dsyme commented 2 years ago

Note I believe we would need to:

KevinRansom commented 2 years ago

@dsyme, we would have to generate localizable xml files as well as improve probing, probably leveraging the .xlf infrastructure. We could do it, and the localizers would pick it up and produce new text, it would actually be great to do.

This is a localized Fench VS with English language tooltips read from the xml docs file. image