"Unused open statements" analyzer does not work on a very simple code

[vasily-kirichenko]

open System
open System.Threading

[<EntryPoint>]
let main _ =
    printfn "%A" System.DateTime.Now
    0

[EBrown8534]

Shouldn't this emit that the name of System.DateTime.Now can be simplified instead?

[vasily-kirichenko]

no, that’s the work of a different analyzer.

[vasily-kirichenko]

this, and many other bugs, has been fixed in https://github.com/Microsoft/visualfsharp/pull/3803

[EBrown8534]

@vasily-kirichenko I meant that this analyzer shouldn't run, and the other one should. I would think that if you open something, and call a method with the FQN including that opened thing, it would not emit this suggestion but instead allow the other analyzer to emit a "name can be simplified" suggestion.

[vasily-kirichenko]

1. turn on the simplify name analyzer in the settings 2. build and install the vsix from my pr I mentioned. After that everything will work properly.

[cartermp]

@EBrown8534 The Simplify Name analyzer is off by default because it's expensive and bogs down the editor due to how document analyzers are run by Roslyn under the covers. You can see a breakdown of what happens in the editor here: https://github.com/dotnet/roslyn/issues/19347#issuecomment-310225540

[EBrown8534]

@cartermp Ah, thanks! That clears things up for me.

[cartermp]

Fixed by #3803