Recursive object reference colored as a mutable variable

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio

https://dotnet.microsoft.com/languages/fsharp

MIT License

3.87k stars 781 forks source link

Recursive object reference colored as a mutable variable #5229

Open asik opened 6 years ago

asik commented 6 years ago

The reference is not mutable, so it should not be colored as a mutable variable.

Visual Studio Enterprise 2017 Version 15.7.4 Visual F# Tools 10.1 for F# 4.1 - 15.7.0.0

dsyme commented 4 years ago

I'm ok with this colorization as it is rarely recommended to use this form (using the this variale available on members almost always suffices in cleanly written code), and it has some performance implications to do so.

cartermp commented 4 years ago

Hmm, I think we should keep this open since it's clearly wrong and at least validate it against the recent classification changes made in VS.