search

dotnet / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
3.89k stars 784 forks source link

No message reported when a ProvidedType has an ObsoleteAttribute #897

Open dsyme opened 8 years ago

dsyme commented 8 years ago

When a provided method or provided property has an ObsoleteAttribute, a message is reported as expected

However when a provided type definition has an ObsoleteAttribute, no message is reported (also applies to provided events, though those are vanishingly rare)

Cause: In src\fsharp\infos.fs, CheckProvidedAttributes is called for properties and methods, but not for type definitions.

edgarfgp commented 9 months ago

@vzarytovskii As we do not have an specific repro for this issue and based in my previous work on Obsolete attribute consistency, I think this is already fixed and can be closed

vzarytovskii commented 9 months ago

@vzarytovskii As we do not have an specific repro for this issue and based in my previous work on Obsolete attribute consistency, I think this is already fixed and can be closed

I'm not entirely sure it's fixed. I don't think we've tested with type providers? They have a different logic iirc. I'll check next week, thanks for pinging.

edgarfgp commented 9 months ago

@vzarytovskii As we do not have an specific repro for this issue and based in my previous work on Obsolete attribute consistency, I think this is already fixed and can be closed

I'm not entirely sure it's fixed. I don't think we've tested with type providers? They have a different logic iirc. I'll check next week, thanks for pinging.

Ohh I see ProvidedType is related TP . Yeah I have not done anything related to TP