search

dotnet / install-scripts

MIT License
128 stars 68 forks source link

require productVersion.txt file lookups to be application/octet-streams #403

Closed baronfel closed 8 months ago

baronfel commented 9 months ago

This is an alternative to #402 - instead of skipping the productversion check, we instead enforce that the file is of the expected content-type. If not, the productVersion is not viable and we fallback to the other ways of determining it. This unblocks the proposed redirect scheme described in #402.

YuliiaKovalova commented 9 months ago

It's unusual for text files to be served as application/octet-stream. Should we get a sign-off from the folks running the server that this is unlikely to change?

I think Ladi caught an issue here. For failed tests productVersion.txt returns: Content-Type text/plain; charset=utf-8. Please see logs attached ErrorLogs.txt SuccessfulLogs.txt

YuliiaKovalova commented 8 months ago

Agreed to close this PR offline