search

dotnet / install-scripts

MIT License
128 stars 68 forks source link

--os should support macos #406

Closed danmoseley closed 7 months ago

danmoseley commented 8 months ago

OSX name changed to macOS in 2016. Even if existing scripts keep using osx, we should support macos as well. Otherwise we look rather out of the loop.

dan@danmose50:/mnt/c/WINDOWS/system32$ /mnt/c/git/install-scripts/src/dotnet-install.sh  -DryRun -Version 8.0.100-rtm.23523.2 --os mac
dotnet_install: Error: 'mac' is not a supported value for --os option, supported values are: osx, linux, linux-musl, freebsd, rhel.6. If you think this is a bug, report it at https://github.com/dotnet/install-scripts/issues.
dan@danmose50:/mnt/c/WINDOWS/system32$ /mnt/c/git/install-scripts/src/dotnet-install.sh  -DryRun -Version 8.0.100-rtm.23523.2 --os osx
baronfel commented 8 months ago

Totally fair - we did this change in the RID graph a while back as well so should take it here to be in sync.

baronfel commented 7 months ago

Closing this as we've merged this and deployed it to the .NET Website.