search

dotnet / install-scripts

MIT License
128 stars 68 forks source link

Correct broken redirects in the case that the response ends without final code 2xx/4xx/5xx #464

Closed GangWang01 closed 2 months ago

GangWang01 commented 2 months ago

Fix

461

Solution

In the case that the response ends without final code 2xx/4xx/5xx, getting broken redirects includes last http code.

YuliiaKovalova commented 2 months ago

Could you please cover the case with .net 9 here and check other places where preview is missed? https://github.com/GangWang01/install-scripts/blob/cc56933f989275e5dabe35441e224845ef9e7a44/tests/Install-Scripts.Test/GivenThatIWantToInstallDotnetFromAScript.cs#L40

The implementation is great, just want to fill the existing gaps in testing ;)

YuliiaKovalova commented 2 months ago

thank you!