dotnet / install-scripts

MIT License
128 stars 68 forks source link

Install SDK respecting global.json configuration #476

Closed mattinsp closed 2 weeks ago

mattinsp commented 3 weeks ago

Is your feature request related to a problem? Please describe.

The dotnet CLI should allow installation of SDK versions respecting the configuration in global.json.

Describe the solution you'd like

dotnet sdk install <version> - version should be optional and omitting it should utilise the global.json file.

Additional context

dotnet-install.ps1. exists and allows a jsonfile to be set but this does not respect the "rollForward" configuration which significantly limits its use.

marcpopMSFT commented 3 weeks ago

Moving since the request is related to the install scripts. We are looking into CLI commands for update/install but those will come in a future release.

YuliiaKovalova commented 3 weeks ago

Hi @baronfel ,

Could you please to prioritize this work? Thank you!

mattinsp commented 3 weeks ago

Moving since the request is related to the install scripts. We are looking into CLI commands for update/install but those will come in a future release.

The problem and requested solution clearly indicate that this is about the dotnet CLI, why was this moved?

YuliiaKovalova commented 3 weeks ago

Moving since the request is related to the install scripts. We are looking into CLI commands for update/install but those will come in a future release.

The problem and requested solution clearly indicate that this is about the dotnet CLI, why was this moved?

cc: @marcpopMSFT

mattinsp commented 3 weeks ago

@YuliiaKovalova I believe https://github.com/dotnet/install-scripts/issues/468 addresses this issues with the install scripts which is good to see, but this also needs implementation in the dotnet CLI of course.

marcpopMSFT commented 3 weeks ago

I moved it as I took the additional context to be about supporting rollforward in the install scripts. It's true that there is also a suggestion to have this capability in the dotnet CLI which would live in the sdk repo but we have an issue tracking improving the acquisition already: https://github.com/dotnet/sdk/issues/14960

So I think since we have 14960 and 468, perhaps this issue can be closed and tracked there?

YuliiaKovalova commented 2 weeks ago

Expected work from install-scripts side will be handled in scope of https://github.com/dotnet/install-scripts/issues/468