Closed am11 closed 1 month ago
@baronfel, could we please deploy this to dot.net after the merge? Iβm concerned that as people start updating to the 10.0 previews, they may run into some unexpected issues on osx-arm64. I discovered this myself (after a cup of β) because the use of Rosetta emulation isn't clearly highlighted, which might lead to confusion about the fact that .NET is actually emulating. π Thanks!
I've asked the team to review, and once we merge we'll definitely work with @mairaw's team to get it updated π
I'm not a Bash person, but it looks good. I would like to add one small change to cover another issue and then I can start the deployment process. It takes some time as we need to test the new version in 4 major .NET repos before publishing to dot.net. But I think it could be done this week.
Thank you! π
Thanks for the PR @am11 :)
It was downloading osx-x64 on osx-arm64 machine due to relaxed pattern matching:
This delta fixes the issue by parsing major version from the input and comparing if it is less than 6.