search

dotnet / installer

.NET SDK Installer
https://github.com/dotnet/sdk
1.27k stars 446 forks source link

Enable Maui workloads for .NET 7 #13361

Closed marcpopMSFT closed 2 months ago

marcpopMSFT commented 2 years ago

We disabled these in #13247. This is to track adding them back once Maui has a chance to create their .net 7 workload manifests

marcpopMSFT commented 2 years ago

@jonathanpeppers we added back the fallback workloads for preview 5. How are .net 7 workloads coming along?

jonathanpeppers commented 2 years ago

I think this should probably work now:

> dotnet workload install maui --source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json --source https://api.nuget.org/v3/index.json --from-rollback https://aka.ms/dotnet/maui/net7.0.json

The .NET fundamentals team is pretty close to using this ^^ in a pipeline to measure performance.

MiYanni commented 3 months ago

The test, Given_multi_target_It_should_get_suggested_workload_by_GetRequiredWorkloads_target, is currently skipped because of this issue. The test fails for a reason similar to:

Expected getValuesCommand.GetValues() {"android", "ios"} to contain {"macos", "android-aot"}, but could not find {"macos", "android-aot"}.

Looks like (potentially) that the expected information (via InlineData) is different than the way the feature operates, but I'm not certain myself. Someone who worked on workloads should investigate. It might be a simple test adjustment if the test is simply outdated.

marcpopMSFT commented 2 months ago

Old issue triage: this was fixed long ago. Yanni reopened as there was a disabled test linked to this that didn't pass when he tried to enable it. @v-wuzhai mind filing an issue in the SDK repo and linking those tests to this (or if you can figure out how to fix those tests, we could enable them again)?