search

dotnet / interactive-window

Visual Studio Interactive Window
MIT License
64 stars 35 forks source link

Remove use of Microsoft.VisualStudio.Text.Internal #202

Closed jasonmalinowski closed 3 years ago

jasonmalinowski commented 3 years ago

Fixes https://github.com/dotnet/interactive-window/issues/126

tmat commented 3 years ago

@genlu Do we still need the hack that's making the PR validation fail?

genlu commented 3 years ago

@tmat Unfortunately yes. If this needs to go in dev16, then we need to create a dev16 branch w/o all the dev17 changes

jasonmalinowski commented 3 years ago

@genlu this doesn't need to go into Dev16 (it's just generic cleanup in support of a larger Roslyn change). But if I wait for Dev17, how long do I have to wait until this is sorted out? I know I'm asking you to predict a schedule, but is that expected to be on the order of weeks or months?

genlu commented 3 years ago

@jasonmalinowski If you are asking when can we get rid of the internal feed, then I'm still hoping it will happen some time this week

jasonmalinowski commented 3 years ago

@genlu I guess though am I allowed to merge this for 17.0 Preview 1, or is that still being reserved for 64-bit changes only?

genlu commented 3 years ago

You can merge now, it's just that there's no way for your to test your change since we don't have VS with new interops yet.