search

dotnet / interactive

.NET Interactive combines the power of .NET with many other languages to create notebooks, REPLs, and embedded coding experiences. Share code, explore data, write, and learn across your apps in ways you couldn't before.
MIT License
2.91k stars 389 forks source link

Polyglot Notebook: [DevExE2E][Regression] The kernelName and language show as csharp in the created Untitled-1.ipynb contents. #3263

Open v-hozha1 opened 1 year ago

v-hozha1 commented 1 year ago

Describe the bug

The kernelName and language show as csharp in the created Untitled-1.ipynb contents which only contains a single cell of type "F#".

Note: It's a regression issue. It doesn't repro on - VSCodeUserSetup-arm64-1.81.1 + dotnet-interactive-vscode-1.0.4454011.vsix + dotnet-sdk-7.0.400-win-x64.

Detailed Repro Build info: VSCodeSetup-x64-1.83.1 +dotnet-interactive-vscode-1.0.4514021.vsix+ dotnet-sdk-7.0.402-win-x64

VS Code: https://update.code.visualstudio.com/1.83.1/win32-x64/stable Version: 1.83.1 (system setup) Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc Date: 2023-10-10T23:48:05.904Z Electron: 25.8.4 ElectronBuildId: 24154031 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.25398

dotnet-interactive-vscode-1.0.4514021.vsix Build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2291238&view=artifacts&pathAsName=false&type=publishedArtifacts

Steps: 1.Open the notebook from https://github.com/dotnet/interactive/blob/main/NotebookTestScript.dib. 2.Ctrl+Shift+P` => "Polyglot Notebook: Create new blank notebook" 3.Select "Create as .ipynb" 4.Select "F#" 5.You should have a new empty notebook named something like "Untitled-1.ipynb" with a single cell of type "F# (Polyglot Notebook)". 6.Set the cell contents to 1+1 and execute.

  1. Save to disk.
  2. Open that file in notepad.
  3. Check the contents of Untitled-1.ipynb

Expected Results: The kernelName and language should be fsharp in the created Untitled-1.ipynb contents. image

Actual Results: The kernelName and language show as csharp in the created Untitled-1.ipynb contents. image

{ "cells": [ { "cell_type": "code", "execution_count": 1, "metadata": { "dotnet_interactive": { "language": "fsharp" }, "polyglot_notebook": { "kernelName": "fsharp" } }, "outputs": [ { "data": { "text/html": [ "<div class=\"dni-plaintext\">

2
" ] }, "metadata": {}, "output_type": "display_data" } ], "source": [ "1+1" ] } ], "metadata": { "kernelspec": { "display_name": ".NET (C#)", "language": "C#", "name": ".net-csharp" }, "language_info": { "name": "polyglot-notebook" }, "polyglot_notebook": { "kernelInfo": { "defaultKernelName": "csharp", "items": [ { "aliases": [], "name": "csharp" }, { "aliases": [], "languageName": "fsharp", "name": "fsharp" } ] } } }, "nbformat": 4, "nbformat_minor": 2 }

Please complete the following:

Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):

Screenshots

If applicable, add screenshots to help explain your problem.

v-hozha1 commented 11 months ago

This issue doesn't repro on VS Code 1.85.1 + dotnet-interactive-vscode-1.0.4611011.vsix + dotnet-sdk-8.0.100. Hence closing it.

Fixed Screenshot: image

image

v-hozha1 commented 6 months ago

This issue reproduces on VSCodeSetup-arm64-1.89.1 + dotnet-interactive-vscode-1.0.5263011.vsix + dotnet-sdk-8.0.300-win-arm64 again. So re-active it.

Repro-notebook