dotnet / interactive

.NET Interactive combines the power of .NET with many other languages to create notebooks, REPLs, and embedded coding experiences. Share code, explore data, write, and learn across your apps in ways you couldn't before.
MIT License
2.8k stars 374 forks source link

Incorrect tooltip for Execute Cell button on Linux #3465

Open IntegerMan opened 4 months ago

IntegerMan commented 4 months ago

Describe the bug

I'm running Polyglot on Pop!_OS 22.04 (a flavor of Ubuntu 22.04) and building text for the book and noticed an incorrect shortcut key for the "Execute Cell" button describing the shortcut as Super + Enter. Super is a substitute for the Windows key on most keyboards. The correct shortcut is still Control + Enter as it is in Windows.

Please complete the following:

Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):

Screenshots

image

IntegerMan commented 4 months ago

This is likely more than just the execute cell shortcut. I just noticed a mistake on the validate markdown shortcut as well: image

I'd recommend reviewing Linux shortcuts for correctness.

jonsequitur commented 4 months ago

This is VS Code functionality, not Polyglot Notebooks.

@rebornix Is this on your radar?

rebornix commented 4 months ago

We are using ctrl+enter as the default keybindings

primary: KeyMod.WinCtrl | KeyCode.Enter,
win: {
    primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.Enter
},

@IntegerMan do you have the Jupyter Keymap installed?

IntegerMan commented 4 months ago

@rebornix I did indeed. I didn't think I did since I have a very minimal install in a new workspace, but perhaps I added it and don't remember doing so. Disabling that gives me better tooltips for the Stop Editing Cell, but not the execute cell shortcut: image Note that the keymap is disabled in this screenshot.