Add GPIO support for Rockchip RV1103

dotnet / iot

This repo includes .NET Core implementations for various IoT boards, chips, displays and PCBs.

MIT License

2.12k stars 574 forks source link

Add GPIO support for Rockchip RV1103 #2303

Closed ZhangGaoxing closed 3 weeks ago

ZhangGaoxing commented 2 months ago

Add GPIO support for Rockchip RV1103 and some boards like LuckFox Pico.

I do some test in LuckFox Pico with pin 137, the OS is Ubuntu 22.04, Linux kernel version is 5.10.110, .NET version is 8.0.203. The GPIO speed is 219KHz

Microsoft Reviewers: Open in CodeFlow

raffaeler commented 2 months ago

Hi @ZhangGaoxing great contribution, thank you. On my side I would love to see comments including:

a link to the official specifications (including relevant pages, where possible)
a bit more descriptions in the constants (Rv1103Driver offsets)

ZhangGaoxing commented 2 months ago

Some datasheets can refer to the following link: https://wiki.luckfox.com/Luckfox-Pico/Datasheets/ and the register offsets I wrote in the code comments 😄

raffaeler commented 2 months ago

Some datasheets can refer to the following link: https://wiki.luckfox.com/Luckfox-Pico/Datasheets/ and the register offsets I wrote in the code comments 😄

I meant something a bit more detailed :-)

The general guidelines applied to the rest of the repository are:

The link should go to the README file, specifying the paragraph or page numbers related to the driver
In the comments, specify the paragraph or page of the datasheet where to find the numbers
Where relevant, create a const int for the numbers that used more than a single time (no need for numbers that are signatures, prefixes, etc)

Thank you for the great work!

Ellerbach commented 1 month ago

[Triage] @ZhangGaoxing it would be perfect if you can address the feedback from @raffaeler. And we don't have the device to test or do anything with it. So please adjust a bit your PR and we will be super happy to review it and approve and of course merge it after. Thanks.

joperezr commented 1 month ago

[Triage] Hey @ZhangGaoxing your PR seems to be in a good state code-wise (thanks for the contribution!), but we think it needs some work in adding a few comments just to explain where some of the registers come from and where can we look at the docs. This is very important to us as it will help us maintain this driver going forward. Do you think you'll have cycles to do a quick pass over those? That way we can go ahead and take the change.

dotnet-policy-service[bot] commented 1 month ago

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days.

dotnet-policy-service[bot] commented 3 weeks ago

Hello @ZhangGaoxing, the reviewers on this PR have requested changes and there has not been any activity for 14 days, so it will be closed for housekeeping pourposes. Feel free to reopen or send a new one if you wish to resume the progress.