search

dotnet / iot

This repo includes .NET Core implementations for various IoT boards, chips, displays and PCBs.
MIT License
2.16k stars 580 forks source link

CONTRIBUTING documentation is way out of date #2334

Closed jdbruner closed 1 month ago

jdbruner commented 2 months ago

Instructions for contributors at Documentation/CONTRIBUTING.md recommend using Visual Studio 2019 on Windows and .NET 6 preview (and even include links to RC preview distributions of .NET 6). At a minimum, this should refer to VS2022 and at least mention using VSCode. It should also point to at least the .NET 6 LTS release; however, with the deprecation of .NET 6 in November, perhaps it is time to encourage people to use .NET 8 instead.

raffaeler commented 2 months ago

You are totally right. Are you willing to create a PR for this document? Thanks!

jdbruner commented 2 months ago

Sure, I'm willing to create a PR, but what should it say about .NET 6 / .NET 8 ?

joperezr commented 2 months ago

Thank you so much for letting us know and for volunteering. Regarding .NET 6 vs .NET 8, we currently build the repo using .NET 7 tooling but have a PR coming to bump that to .NET 8, so in terms of recommendation, we would like to mention that .NET 8 SDK should be installed (or latest VS which would include if developing in Windows). In terms of what framework we target, we currently target .NET 6, but that is going out of support in November, so we also have a PR coming soon-ish that will bump the target framework as well to ensure we target supported platforms only (which echoes what other dotnet repos like dotnet/runtime does).

Please don't hesitate to ask other questions, and let us know if there is any other information we can provide to help 😃