search

dotnet / issue-labeler

An issue labeler bot for use in dotnet repositories.
MIT License
22 stars 20 forks source link

3 small fixes: strip newlines from issue titles, fix warning, and add dotnet/msbuild repo #41

Closed Eilon closed 2 years ago

Eilon commented 2 years ago

3 fixes:

  1. Remove invalid characters from issue titles - Apparently newlines are valid in GitHub issue titles! This code makes sure they are stripped out, or else it breaks the TSV file because it has extra newlines.
  2. Fix compiler warning about re-throwing an exception
  3. Add dotnet/msbuild to repos.json

The first change is very important because some repos (dotnet/aspnetcore) have newlines (hex 0x0A) in issue titles! Yes, GitHub actually allows that! There was exactly 1 place where we weren't stripping those characters so I fixed that. The other 2 are just minor fixes/improvements.