search

dotnet / issue-labeler

An issue labeler bot for use in dotnet repositories.
MIT License
22 stars 19 forks source link

Use configuration instead of hard-coded settings #62

Closed jeffhandley closed 1 year ago

jeffhandley commented 1 year ago

This moves away from hard-coded conditions for repos and adopts configuration much more heavily. I've also updated the logic for getting settings from config, moving from GetSection(key).Get<T>() to GetValue<T>(key, default).

For every condition that has been moved to config in this PR, I've already updated the service configuration to capture what was encoded here.

These changes have not yet been deployed. I will await code reviews.

jeffhandley commented 1 year ago

This is deployed. I ended up following up with another commit to correct where I'd not yet cleaned up a renamed config setting.

https://github.com/dotnet/issue-labeler/commit/a97d745efcfc5c2915522dad167d952f497c1735