search

dotnet / issue-labeler

An issue labeler bot for use in dotnet repositories.
MIT License
21 stars 19 forks source link

Bot is creating duplicate "new API" comments #77

Open stephentoub opened 2 weeks ago

stephentoub commented 2 weeks ago

e.g. https://github.com/dotnet/runtime/pull/103308#issuecomment-2161508792

Image

ericstj commented 2 weeks ago

I can repro with the test endpoint of the webhook controller - this will add 2 comments - so it's not a case of github calling the webhook too many times.

I suspect that this commentOn method is retrying https://github.com/dotnet/issue-labeler/blob/0571c524404b80334144e365a4449bb111565ceb/src/GitHubHelpers/GitHubClientWrapper.cs#L77C22-L77C42

ericstj commented 2 weeks ago

I tested that theory by enabling logs for the app service and triggering the test endpoint. I didn't observe a failure in the log (which I would expect for a retry here) so either it's not retrying - or the log is set up correctly for this component.