search

dotnet / jitutils

MIT License
144 stars 59 forks source link

RLCSE: add some validation, consistently divide by base #402

Closed AndyAyersMS closed 6 months ago

AndyAyersMS commented 6 months ago

Add some sanity checks that the SPMI collection and the SPMI tool are of the same vintage. It would be nice if MCHs conveyed this information directly but for typical usage we can rely in the guid being there in the file name.

Would be nice to do similar for collection Os/Arch but am not doing that yet.

Attempt to create the output dir if it does not exist.

Consistently divide by the base value when comparing against best. This means good comparison values are always less than 1, and bad one greater than one.

AndyAyersMS commented 6 months ago

@EgorBo PTAL cc @dotnet/jit-contrib @NoahIslam @LogarithmicFrog1