search

dotnet / jitutils

MIT License
144 stars 59 forks source link

Use clang-format/clang-tidy version 17.0.6 #408

Closed BruceForstall closed 5 months ago

BruceForstall commented 5 months ago

These are now uploaded in a new location in JIT Azure Storage for three platforms currently:

So jit-format will work on any of these platforms now.

Note that osx-x64 is no longer supported for clang-format/clang-tidy.

This includes https://github.com/dotnet/jitutils/pull/407.

BruceForstall commented 5 months ago

This requires https://github.com/dotnet/runtime/pull/100498 (which also depends on this change).

BruceForstall commented 5 months ago

@dotnet/jit-contrib

am11 commented 5 months ago

FWIW, the bleeding edge version is https://github.com/llvm/llvm-project/releases/tag/llvmorg-18.1.2, in case we want to opt for latest stable. Apple Clang has different versioning scheme, which does not correspond to llvmorg versions; current latest satble version on fully updated osx-arm64 machine is 1500.3.9.4 which corresponds to llvm 16.0.0 (https://en.wikipedia.org/wiki/Xcode#Xcode_15.0_-_(since_visionOS_support)_2).

BruceForstall commented 5 months ago

FWIW, the bleeding edge version is https://github.com/llvm/llvm-project/releases/tag/llvmorg-18.1.2, in case we want to opt for latest stable. Apple Clang has different versioning scheme, which does not correspond to llvmorg versions; current latest satble version on fully updated osx-arm64 machine is 1500.3.9.4 which corresponds to llvm 16.0.0 (https://en.wikipedia.org/wiki/Xcode#Xcode_15.0_-_(since_visionOS_support)_2).

@am11 Thanks for the review!

I went for 17.0.6 instead of 18 partially because there was prebuilt Ubuntu 22.04 binaries. And it's new but not too "bleeding edge". As for Apple, well, the LLVM github release does have osx-arm64 built bits.