search

dotnet / jitutils

MIT License
144 stars 59 forks source link

add instruction dump if decoding fails #411

Closed SzpejnaDawid closed 3 months ago

SzpejnaDawid commented 4 months ago

If decoding of instruction fails, libcoredistools will dump this instruction in hex. Normally, finding the source of Decode Failure is pretty tedious (especially for someone new). My code is analogous to dumpInstruction(...) implementation.

Part of dotnet/runtime#84834, cc @dotnet/samsung

clamp03 commented 3 months ago

@BruceForstall Could you review this PR?

BruceForstall commented 3 months ago

@kunalspathak @jakobbotsch PTAL

jakobbotsch commented 3 months ago

Going to close and reopen this to rerun CI since there was a coredistools related build failure which I can't see the details of.

jakobbotsch commented 3 months ago

The failure doesn't seem related.